Re: [PATCH v10 1/2] pinctrl: pinctrl-loongson2: add pinctrl driver support

From: Yinbo Zhu
Date: Wed Nov 16 2022 - 02:39:17 EST




在 2022/11/15 下午9:38, Rob Herring 写道:
On Mon, Nov 14, 2022 at 10:49:41AM +0800, Yinbo Zhu wrote:
From: zhanghongchen <zhanghongchen@xxxxxxxxxxx>

The Loongson-2 SoC has a few pins that can be used as GPIOs or take
multiple other functions. Add a driver for the pinmuxing.

There is currently no support for GPIO pin pull-up and pull-down.

Signed-off-by: zhanghongchen <zhanghongchen@xxxxxxxxxxx>
Co-developed-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
---
Change in v10:
1. Remove lio/uart2/uart1/carmera/dvo1/dvo0 pins resue configuration.
2. Remove the castings about readl/writel/definition addr.
Change in v9:
1. Add zhanghongchen as patch author and add Co-developed-by tag
for myself.
2. Keep entry in order in Kconfig and Makefile.
3. Keep it as a separate group after generic linux/* ones.
4. Use linux/io.h replace asm-generic/io.h.
5. Use PINCTRL_PINGROUP() and associated data structure.
6. Remove Redundant blank line after loongson2_pmx_groups.
7. Adjust gpio_groups.
8. Remove message printk after devm_platform_ioremap_resource.
9. Remove comma for the terminator line.
10. Add MODULE_LICENSE("GPL") in driver ending.
Change in v8:
1. Add #include <linux/pinctrl/pinctrl.h>.
2. Add #include <linux/seq_file.h>.
Change in v7:
1. Add all history change log information.

Linus applied v7 already. Additional changes need to be incremental
patches on top of it.

Rob
okay, I got it.