Re: [PATCH v10 1/2] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver

[Bagas Sanjaya]

On Wed, Nov 16, 2022 at 08:31:32AM +0800, Jiucheng Xu wrote:
> This patch adds support Amlogic meson G12 series SoC
> DDR bandwidth PMU driver framework and interfaces.
> 
> The PMU not only can monitor the total DDR bandwidth,
> but also the bandwidth which is from individual IP module.
> 

Please write the patch description in imperative mood (no "This patch/commit
does foo" but "Do foo" instead).

What about this description below?

```
Add support for Amlogic Meson G12 Series SOC - DDR bandwidth PMU driver
framework and interfaces. The PMU can not only monitor the total DDR
bandwidth, but also individual IP module bandwidth.
```

> Example usage:
> 
>  $ perf stat -a -e meson_ddr_bw/total_rw_bytes/ -I 1000 sleep 10
> 
> - or -
> 
>  $ perf stat -a -e \
>    meson_ddr_bw/total_rw_bytes/,\
>    meson_ddr_bw/chan_1_rw_bytes,arm=1/ -I 1000 \
>    sleep 10
> 
> g12 SoC support 4 channels to monitor DDR bandwidth
> simultaneously. Each channel can monitor up to 4 IP modules
> simultaneously.
> 
> For Instance, If you want to get the sum of DDR bandwidth
> from CPU, GPU, USB3.0 and VDEC. You can use the following
> command parameters to display.
> 
>  $ perf stat -a -e \
>    meson_ddr_bw/chan_2_rw_bytes,arm=1,gpu=1,usb3_0=1,nna=1/ -I 1000 \
>    sleep 10
> 
> Other events are supported, and advertised via perf list.

The demo example should have been outside the patch description, though
(more appropriate documentation as in patch [2/2]).

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Attachment: signature.asc
Description: PGP signature