Re: [PATCH v2 05/11] dt-bindings: mailbox: qcom: Allow syscon on qcom,msm8976-apcs-kpss-global

[AngeloGioacchino Del Regno]

Il 16/11/22 09:57, Krzysztof Kozlowski ha scritto:
> On 16/11/2022 09:52, AngeloGioacchino Del Regno wrote:
> > Il 15/11/22 17:44, Krzysztof Kozlowski ha scritto:
> > > On 11/11/2022 13:01, AngeloGioacchino Del Regno wrote:
> > > > MSM8976 supports SMSM, which needs this node to also be a syscon:
> > > > move the compatible to allow that.
> > > >
> > > > Fixes: bcc8d70f912d ("dt-bindings: mailbox: Add compatible for the MSM8976")
> > >
> > > I am not sure if this is still a bug. Maybe just a missing feature?
> >
> > This changes how you use this mailbox across the entire devicetree (as other
> > nodes will not use mboxes = xxxx, but qcom,ipc = xxxx as syscon), so I think
> > that this is not a missing feature?
>
> Whether it is a bug depends on existing usage. If none of msm8976 DTSes
> use it the other way, then it is just incomplete or missing support. Not
> a bug. If existing DTSes use it as syscon, thus you need to add syscon
> to compatible, then it would be a bugfix.

It's not a bugfix then. The Fixes tag shall be dropped.

Same question like the other commit, should I send a v3 or can it be dropped while
applying?