Re: [PATCH] cifs: Fix problem with encrypted RDMA data read

From: Stefan Metzmacher
Date: Wed Nov 16 2022 - 04:05:23 EST


Am 16.11.22 um 08:00 schrieb David Howells:
Stefan Metzmacher <metze@xxxxxxxxx> wrote:

I'm not sure I understand why this would fix anything when encryption is
enabled.

Is the payload still be offloaded as plaintext? Otherwise we wouldn't have
use_rdma_mr... So this rather looks like a fix for the non encrypted case.

The "inline"[*] PDUs are encrypted, but the direct RDMA data transmission is
not. I'm not sure if this is a bug in ksmbd.

It's a bug in the client!

As I understand it, encrypting and decrypting the directly transferred
data would need to be done by the NIC, not the cifs driver.

No, the encryption needs to happen above the RDMA/NIC layer.

metze