Re: [PATCH 2/4] dt-bindings: pinctrl: qcom,tlmm-common: document i2c pull property
From: Krzysztof Kozlowski
Date: Wed Nov 16 2022 - 06:22:47 EST
On 16/11/2022 11:57, Abel Vesa wrote:
> From: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
>
> Document the new i2c_pull property introduced for SM8550 setting
> an I2C specific pull mode on I2C able pins.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
Your SoB is missing and this patch cannot be before the first.
> ---
> .../devicetree/bindings/pinctrl/qcom,tlmm-common.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
> index e1354f0c64f8..eddd58eafba9 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
> @@ -77,6 +77,9 @@ $defs:
> input-enable: true
> output-high: true
> output-low: true
> + qcom,i2c-pull:
> + type: boolean
> + description: enable bias pull feature designed for i2c on pin
s/i2c/I2C/
>
> allOf:
> - $ref: pincfg-node.yaml#
Best regards,
Krzysztof