Re: [PATCH v2] scripts/kallsyms.c Make the comment up-to-date with current implementation

From: Miguel Ojeda
Date: Wed Nov 16 2022 - 15:05:00 EST


On Tue, Nov 15, 2022 at 10:26 PM Yuma Ueda <cyan@xxxxxxxxxxxx> wrote:
>
> The comment in scripts/kallsyms.c describing the usage of
> scripts/kallsyms does not reflect the latest implementation.
> Fix the comment to be up-to-date with the current implementation.

It may be a good idea to say in the commit message that this is now
equivalent to what the `usage()` function prints (and possibly change
`scripts/kallsyms` to just `kallsyms` to make it exactly equal). In
fact, we could replace the comment with "See usage() function" to
avoid further desyncs... But that is a different patch :)

Also, I am not sure we want to use tabs on the comment -- the rest of
it uses spaces.

Cheers,
Miguel