Re: [PATCH RFC] kexec: Freeze processes before kexec

From: Steven Rostedt
Date: Wed Nov 16 2022 - 15:15:33 EST


On Wed, 16 Nov 2022 19:56:24 +0000
"Joel Fernandes (Google)" <joel@xxxxxxxxxxxxxxxxx> wrote:

> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -1175,6 +1175,12 @@ int kernel_kexec(void)
> } else
> #endif
> {
> + error = freeze_processes();
> + if (error) {
> + error = -EBUSY;
> + goto Unlock;
> + }

If this is the path of a kernel panic, do we really want to check the
return error of freeze_processes()? We are panicing, there's not much more
we can do.

-- Steve


> +
> kexec_in_progress = true;
> kernel_restart_prepare("kexec reboot");
> migrate_to_reboot_cpu();