On Wed. 16 Nov. 2022 at 07:50, Saeed Mahameed <saeed@xxxxxxxxxx> wrote:
On 13 Nov 13:01, Vincent Mailhol wrote:
>ES58x devices report below information in their usb product info
>string:
>
> * the firmware version
> * the bootloader version
> * the hardware revision
>
>Parse this string, store the results in struct es58x_dev and create
>three new sysfs entries.
>
will this be the /sys/class/net/XXX sysfs ?
I am dropping the idea of using sysfs and I am now considering using
devlink following Andrew's message:
https://lore.kernel.org/linux-can/Y3Ef4K5lbilY3EQT@xxxxxxx/
We try to avoid adding device specific entries in there,
Couldn't you just squeeze the firmware and hw version into the
ethtool->drvinfo->fw_version
something like:
fw_version: %3u.%3u.%3u (%c.%3u.%3u)
This looks like a hack. There is no way for the end user to know, just
from the ethtool output, what these in brackets values would mean.
and bootloader into ethtool->drvinfo->erom_version:
* @erom_version: Expansion ROM version string; may be an empty string
Same. I considered doing this in the early draft of this series and
dropped the idea because an expansion ROM and a boot loader are two
things different.
I will continue to study devlink and only use the drvinfo only for the
firmware version.