Re: [PATCH 1/2] PCI: loongson: add skip-scan property for child DT node
From: Dan Carpenter
Date: Wed Nov 16 2022 - 23:12:37 EST
Hi Liu,
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Liu-Peibao/PCI-loongson-add-skip-scan-property-for-child-DT-node/20221103-170125
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
patch link: https://lore.kernel.org/r/20221103090040.836-1-liupeibao%40loongson.cn
patch subject: [PATCH 1/2] PCI: loongson: add skip-scan property for child DT node
config: loongarch-randconfig-m041-20221114
compiler: loongarch64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <error27@xxxxxxxxx>
smatch warnings:
drivers/pci/controller/pci-loongson.c:257 setup_masklist() error: not allocating enough for = 'entry' 24 vs 8
vim +/entry +257 drivers/pci/controller/pci-loongson.c
f93e71fb8e65ba Liu Peibao 2022-11-03 242 static int setup_masklist(struct loongson_pci *priv)
f93e71fb8e65ba Liu Peibao 2022-11-03 243 {
f93e71fb8e65ba Liu Peibao 2022-11-03 244 struct device *dev = &priv->pdev->dev;
f93e71fb8e65ba Liu Peibao 2022-11-03 245 struct device_node *dn, *parent = dev->of_node;
f93e71fb8e65ba Liu Peibao 2022-11-03 246 struct mask_entry *entry;
f93e71fb8e65ba Liu Peibao 2022-11-03 247 int devfn;
f93e71fb8e65ba Liu Peibao 2022-11-03 248
f93e71fb8e65ba Liu Peibao 2022-11-03 249 INIT_LIST_HEAD(&priv->masklist);
f93e71fb8e65ba Liu Peibao 2022-11-03 250
f93e71fb8e65ba Liu Peibao 2022-11-03 251 for_each_child_of_node(parent, dn) {
f93e71fb8e65ba Liu Peibao 2022-11-03 252 if (of_property_read_bool(dn, "skip-scan")) {
f93e71fb8e65ba Liu Peibao 2022-11-03 253 devfn = of_pci_get_devfn(dn);
f93e71fb8e65ba Liu Peibao 2022-11-03 254 if (devfn < 0)
f93e71fb8e65ba Liu Peibao 2022-11-03 255 continue;
f93e71fb8e65ba Liu Peibao 2022-11-03 256
f93e71fb8e65ba Liu Peibao 2022-11-03 @257 entry = devm_kzalloc(dev, sizeof(entry), GFP_KERNEL);
^^^^^^^^^^^^^
Should be sizeof(*entry)
f93e71fb8e65ba Liu Peibao 2022-11-03 258 if (!entry)
f93e71fb8e65ba Liu Peibao 2022-11-03 259 return -ENOMEM;
f93e71fb8e65ba Liu Peibao 2022-11-03 260
f93e71fb8e65ba Liu Peibao 2022-11-03 261 entry->devfn = devfn;
f93e71fb8e65ba Liu Peibao 2022-11-03 262 list_add_tail(&entry->entry, &priv->masklist);
f93e71fb8e65ba Liu Peibao 2022-11-03 263 }
f93e71fb8e65ba Liu Peibao 2022-11-03 264 }
f93e71fb8e65ba Liu Peibao 2022-11-03 265
f93e71fb8e65ba Liu Peibao 2022-11-03 266 return 0;
f93e71fb8e65ba Liu Peibao 2022-11-03 267 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp