Re: [PATCH 1/4] dt-bindings: remoteproc: qcom: adsp: document sm8550 adsp, cdsp & mpss compatible

[Neil Armstrong]

On 17/11/2022 00:39, Rob Herring wrote:
> On Wed, Nov 16, 2022 at 01:28:11PM +0100, Krzysztof Kozlowski wrote:
> > On 16/11/2022 11:20, Neil Armstrong wrote:
> > > This documents the compatible for the component used to boot the
> > > aDSP, cDSP and MPSS on the SM8550 SoC.
> > >
> > > The SM8550 boot process on SM8550 now requires a secondary "Devicetree"
> > > firmware to be passed along the main Firmware, and the cDSP a new power
> > > domain named "NSP".
> > >
> > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > > ---
> > >   .../devicetree/bindings/remoteproc/qcom,adsp.yaml  | 60 +++++++++++++++++++++-
> > >   1 file changed, 59 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> > > index db9e0f0c2bea..678cb73f10de 100644
> > > --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> > > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> > > @@ -55,6 +55,9 @@ properties:
> > >         - qcom,sm8450-cdsp-pas
> > >         - qcom,sm8450-mpss-pas
> > >         - qcom,sm8450-slpi-pas
> > > +      - qcom,sm8550-adsp-pas
> > > +      - qcom,sm8550-cdsp-pas
> > > +      - qcom,sm8550-mpss-pas
> > >   
> > >     reg:
> > >       maxItems: 1
> > > @@ -116,8 +119,13 @@ properties:
> > >       $ref: /schemas/types.yaml#/definitions/string
> > >       description: Firmware name for the Hexagon core
> > >   
> > > +  qcom,dtb-firmware-name:
> > > +    $ref: /schemas/types.yaml#/definitions/string
> > > +    description: Devicetree Firmware name for the Hexagon core
> >
> > Not sure about this one.
> >
> > Rob,
> > Don't we want rather to have multiple items in firmware-name?
>
> Yes, I think we already have that for some users. Should have been
> 'firmware-names' I guess but I don't think it's worth dealing with
> another case of handling both (forever).

I'll be happy to switch to a single property but yeah, firmware-name isn't right
for multiple names...

Anyway, will follow qcom,sc7180-mss-pil.yaml since they already use 2 entries there.

Neil

> Rob