Re: [PATCH v2 06/23] arm64: dts: Update cache properties for broadcom

[Pierre Gondois]

On 11/16/22 19:22, Florian Fainelli wrote:
> On 11/7/2022 9:58 AM, Pierre Gondois wrote:
> > On 11/7/22 18:31, Florian Fainelli wrote:
> > > (way too many recipients, gmail's SMTP server would not allow me to
> > > respond unless I moved most people to BCC now done).
> > >
> > > On 11/7/22 07:56, Pierre Gondois wrote:
> > > > The DeviceTree Specification v0.3 specifies that the cache node
> > > > 'compatible' and 'cache-level' properties are 'required'. Cf.
> > > > s3.8 Multi-level and Shared Cache Nodes
> > > > The 'cache-unified' property should be present if one of the
> > > > properties for unified cache is present ('cache-size', ...).
> > > >
> > > > Update the Device Trees accordingly.
> > > >
> > > > Signed-off-by: Pierre Gondois <pierre.gondois@xxxxxxx>
> > > > Acked-by: William Zhang <william.zhang@xxxxxxxxxxxx>
> > >
> > > This looks fine, but incomplete, you seem to have missed:
> > >
> > > - adding 'cache-unified' to all of the cache nodes modified in this
> > > patch set that did not have one already
> > >
> > > - bcm63148.dtsi, bcm63178.dtsi, bcm6756.dtsi, bcm6846.dtsi,
> > > bcm6855.dtsi, bcm6878.dtsi, bcm47622.dtsi
> > >
> > > Thanks
> >
> > I indeed forgot to update some platforms in the broadcom folder.
> > The other folders should be complete.
>
> Can I expect a resend in the next few days so we have a chance of
> getting that included in 6.2? Thanks

Yes sure. Just to check, the 'cache-unified' property is only required
by the DT spec when there is one of these properties in the cache node:
  'cache-[size|line-size|block-size|sets|level]'

So the below doesn't require it. Do you still want to have it added ?

L2_0: l2-cache0 {
	compatible = "cache";
	cache-level = <2>;
};