Re: [PATCH linux-next] selftests/vm: add CATEGORY for ksm_functional_tests

[David Hildenbrand]

On 27.10.22 19:00, Joel Savitz wrote:
> commit e080ceaa69c1 ("selftests/vm: add KSM unmerge tests") in
> linux-next adds an entry to run_vmtests.sh. I recently submitted
> commit b5ba705c2608 ("selftests/vm: enable running select groups of tests")
> to linux-next which categorizes tests by functionality in order to
> allow more precise selection of which tests are to be run.
>
> Since this newest test targets ksm and does not require more than one
> numa node, add 'CATEGORY="ksm"' to the invocation to group this test
> with the other ksm tests.
>
> Signed-off-by: Joel Savitz <jsavitz@xxxxxxxxxx>
> ---
>   tools/testing/selftests/vm/run_vmtests.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh
> index af35dd3bc589..fff00bb77086 100755
> --- a/tools/testing/selftests/vm/run_vmtests.sh
> +++ b/tools/testing/selftests/vm/run_vmtests.sh
> @@ -252,7 +252,7 @@ CATEGORY="ksm_numa" run_test ./ksm_tests -N -m 1
>   # KSM test with 2 NUMA nodes and merge_across_nodes = 0
>   CATEGORY="ksm_numa" run_test ./ksm_tests -N -m 0
>   
> -run_test ./ksm_functional_tests
> +CATEGORY="ksm" run_test ./ksm_functional_tests
>   
>   # protection_keys tests
>   if [ -x ./protection_keys_32 ]

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb