Re: [PATCH] pwm: Add missing dummy for devm_pwmchip_add()

[Uwe Kleine-König]

Hello,

On Wed, Oct 26, 2022 at 09:05:42AM +0200, Geert Uytterhoeven wrote:
> On Wed, Oct 26, 2022 at 2:17 AM Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> > On Tue, Oct 25, 2022 at 04:03:42PM +0200, Geert Uytterhoeven wrote:
> > > The PWM subsystem supports compile-testing if CONFIG_PWM is disabled.
> > > However, no dummy is provided for devm_pwmchip_add(), which may lead to
> > > build failures.
> > >
> > > Fixes: bcda91bf86c1ff76 ("pwm: Add a device-managed function to add PWM chips")
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> >
> > Is this a problem that today yields a failure to compile? As of v6.1-rc1
> > and also in next all callers are below drivers/pwm/ which isn't included
> > in the build without PWM=y.
> 
> So none of these support compile-testing with CONFIG_PWM=n...

There are not many pwm providers outside of drivers/pwm:

 - drivers/gpio/gpio-mvebu.c
 - drivers/gpu/drm/bridge/ti-sn65dsi86.c
 - drivers/leds/rgb/leds-qcom-lpg.c
 - drivers/staging/greybus/pwm.c

These all call pwmchip_add() which has a dummy.

gpio-mvebu only uses it in an if (IS_ENABLED(CONFIG_PWM)) block.
ti-sn65dsi86 has it in a big #ifdef CONFIG_PWM block (and in a dedicated
driver such that the returned error doesn't hurt).

leds-qcom-lpg.c depends on PWM as does the greybus stuff.

So the dummy isn't even needed. (Unless for the corner case GPIO_MVEBU=y
+ PWM=m which is probably a bug worth fixing. Maybe a similar issue
exists for ti-sn65dsi86.)

> > Am I missing something or is this just preparing that one of the drivers
> > that doesn't live in drivers/pwm might call devm_pwmchip_add in the
> > future?
> 
> I saw it with the RZ/G2L MTU3 PWM driver[1], which is not yet applied.
> After noticing its sibling counter driver lacked a dependency on
> CONFIG_COUNTER, I tried disabling CONFIG_PWM...
> 
> > In that case I wouldn't add that Fixes: line (and also oppose to
> > backporting that commit to stable).
> 
> I tend to disagree: more drivers may be converted to devm_pwmchip_add()
> in the future, possibly as part of a fix, causing troubles for the
> stable team when backporting such fixes.

Please don't backport as a precaution not to miss to backport it in case
there is another patch that depends on it. In my experience the stable
maintainers are good at identifying such dependencies.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature