Re: [PATCH] dt-bindings: thermal: qcom-tsens: Add compatible for sm8550

[Krzysztof Kozlowski]

On 17/11/2022 09:06, Neil Armstrong wrote:
> Hi,
> 
> On 16/11/2022 12:26, Krzysztof Kozlowski wrote:
>> On 16/11/2022 11:09, Neil Armstrong wrote:
>>> The Qualcomm SM8550 platform has three instances of the tsens block,
>>> add a compatible for these instances.
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
>>> ---
>>> To: Andy Gross <agross@xxxxxxxxxx>
>>> To: Bjorn Andersson <andersson@xxxxxxxxxx>
>>> To: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
>>> To: Amit Kucheria <amitk@xxxxxxxxxx>
>>> To: Thara Gopinath <thara.gopinath@xxxxxxxxx>
>>> To: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
>>> To: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
>>> To: Zhang Rui <rui.zhang@xxxxxxxxx>
>>> To: Rob Herring <robh+dt@xxxxxxxxxx>
>>> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
>>> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
>>> Cc: linux-pm@xxxxxxxxxxxxxxx
>>> Cc: devicetree@xxxxxxxxxxxxxxx
>>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>>> ---
>>>   Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>> index f0bd4b979e28..09dbd96d380e 100644
>>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>> @@ -58,6 +58,7 @@ properties:
>>>                 - qcom,sm8250-tsens
>>>                 - qcom,sm8350-tsens
>>>                 - qcom,sm8450-tsens
>>> +              - qcom,sm8550-tsens
>>
>> alOf:if:then should be updated.
> 
> I thought the -v2 fallback would be enough since 8450 isn't present either in the alOf:if:then either.
> 
> Anyway, will fix this.


No, you are right. The v2 fallback is already in several allOf:if:then,
so this should be fine.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof