[PATCH v2 4/4] pwm: Don't initialize list head before calling list_add()
From: Uwe Kleine-König
Date: Thu Nov 17 2022 - 16:12:23 EST
list_add() just overwrites the members of the element to add (here:
chip->list) without any checks, even in the DEBUG_LIST case. So save the
effort to initialize the list.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
---
drivers/pwm/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index b43b24bd3c9f..61bacd8d9b44 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -299,7 +299,6 @@ int pwmchip_add(struct pwm_chip *chip)
radix_tree_insert(&pwm_tree, pwm->pwm, pwm);
}
- INIT_LIST_HEAD(&chip->list);
list_add(&chip->list, &pwm_chips);
mutex_unlock(&pwm_lock);
--
2.38.1