Re: [PATCH] power: supply: Added check for negative values

[Sebastian Reichel]

Hi,

On Thu, Nov 17, 2022 at 03:01:40PM +0300, Denis Arefev wrote:
> Variable 'pirq', which may receive negative value
> in platform_get_irq().
> Used as an index in a function regmap_irq_get_virq().
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Denis Arefev <arefev@xxxxxxxxx>
> ---

The patch does not apply. Looks like the patch is based against
ancient code (pre 2022). Also the patch subject prefix should be
'power: supply: axp288_fuel_gauge:'

Thanks,

-- Sebastian

>  drivers/power/supply/axp288_fuel_gauge.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> index 148eb8105803..36c7039c99c2 100644
> --- a/drivers/power/supply/axp288_fuel_gauge.c
> +++ b/drivers/power/supply/axp288_fuel_gauge.c
> @@ -640,6 +640,8 @@ static void fuel_gauge_init_irq(struct axp288_fg_info *info)
>  
>  	for (i = 0; i < AXP288_FG_INTR_NUM; i++) {
>  		pirq = platform_get_irq(info->pdev, i);
> +		if (pirq < 0)
> +			continue;
>  		info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq);
>  		if (info->irq[i] < 0) {
>  			dev_warn(&info->pdev->dev,
> -- 
> 2.25.1
>

Attachment: signature.asc
Description: PGP signature