Re: Remove traceevent from tools/lib

From: Ian Rogers
Date: Thu Nov 17 2022 - 17:52:45 EST


On Thu, Nov 17, 2022 at 10:42 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Thu, 17 Nov 2022 09:59:46 -0800
> Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> > Means that perf is cleanly(ish) separated from libraries in tools/lib.
> > traceevent in tools/lib is out of date (~2years - version 1.1.0 whilst
> > the latest is 1.6.3 [1]) . Should we delete traceevent from tools/lib
>
> Yes please!
>
> Strongly-acked-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

I sent v1 patches:
https://lore.kernel.org/lkml/20221117224952.358639-1-irogers@xxxxxxxxxx/

Thanks,
Ian

> -- Steve
>
> > and just make LIBTRACEEVENT_DYNAMIC the only supported perf build
> > option? I guess this may break old distributions that may not have
> > libtraceevent, but even so I'm not sure that should motivate not
> > cleaning this up (if they are building perf they can build
> > libtraceevent).
>