Re: [EXTERNAL] Re: [PATCH v8 1/6] dt-bindings: remoteproc: Add PRU consumer bindings
From: Md Danish Anwar
Date: Fri Nov 18 2022 - 00:49:22 EST
Hi Mathieu,
On 16/11/22 23:39, Mathieu Poirier wrote:
> On Wed, Nov 16, 2022 at 10:09:48AM -0600, Rob Herring wrote:
>> On Wed, Nov 16, 2022 at 05:46:29PM +0530, MD Danish Anwar wrote:
>>> From: Suman Anna <s-anna@xxxxxx>
>>>
>>> Add DT schema binding for PRU consumers. The binding includes
>>> all the common properties that can be used by different PRU consumer
>>> or application nodes and supported by the PRU remoteproc driver.
>>> These are used to configure the PRU hardware for specific user
>>> applications.
>>>
>>> The application nodes themselves should define their own bindings.
>>>
>>> Co-developed-by: Tero Kristo <t-kristo@xxxxxx>
>>> Co-developed-by: Suman Anna <s-anna@xxxxxx>
>>> Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@xxxxxxxxxx>
>>> Co-developed-by: Puranjay Mohan <p-mohan@xxxxxx>
>>> Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx>
>>
>> Run checkpatch.pl and fix the warnings with the tags.
>
> My bad - I asked Danish to remove the SoBs to lighten the changelog
> presentation. Danish, do you absolutely need to list everyone that touched that
> patchset? If so I suppose just listing the SoBs would be a compromise.
>
I started working on this patch series after version 5. In the first version of
this patch series below were the tags.
Co-developed-by: Tero Kristo <t-kristo@xxxxxx>
Signed-off-by: Tero Kristo <t-kristo@xxxxxx>
Signed-off-by: Suman Anna <s-anna@xxxxxx>
Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@xxxxxxxxxx>
Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@xxxxxxxxxx>
I am not sure whom to drop and whom to keep that's why I have been keeping all
the tags that were present from the beginning.
In the next version I'll keep only the SoBs tags of the the people listed above.
>>
>> You didn't add review/ack tags either.
>
> Those are important.
>
> Please send another patchset that clears checkpatch with review/acks and I'll
> look at it.
>
I am really sorry for that, I was not aware about adding review tags as I am
very new to upstreaming.
I will share new version after fixing checkpatch errors/warnings and adding
review tags.
Thanks,
Danish.
> Thanks,
> Mathieu
>
>>
>>> ---
>>> .../bindings/remoteproc/ti,pru-consumer.yaml | 60 +++++++++++++++++++
>>> 1 file changed, 60 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml