Re: [PATCH] macsec: Fix invalid error code set

[Antoine Tenart]

Quoting YueHaibing (2022-11-18 02:12:49)
> 'ret' is defined twice in macsec_changelink(), when it is set in macsec_is_offloaded
> case, it will be invalid before return.
> 
> Fixes: 3cf3227a21d1 ("net: macsec: hardware offloading infrastructure")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Reviewed-by: Antoine Tenart <atenart@xxxxxxxxxx>

Thanks!

> ---
>  drivers/net/macsec.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
> index a7b46219bab7..d73b9d535b7a 100644
> --- a/drivers/net/macsec.c
> +++ b/drivers/net/macsec.c
> @@ -3835,7 +3835,6 @@ static int macsec_changelink(struct net_device *dev, struct nlattr *tb[],
>         if (macsec_is_offloaded(macsec)) {
>                 const struct macsec_ops *ops;
>                 struct macsec_context ctx;
> -               int ret;
>  
>                 ops = macsec_get_ops(netdev_priv(dev), &ctx);
>                 if (!ops) {
> -- 
> 2.20.1
>