RE: [PATCH v3 01/10] iio: adis: add '__adis_enable_irq()' implementation

[Sa, Nuno]

> -----Original Message-----
> From: Ramona Bolboaca <ramona.bolboaca@xxxxxxxxxx>
> Sent: Friday, November 18, 2022 9:31 AM
> To: jic23@xxxxxxxxxx; Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; linux-
> iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Bolboaca, Ramona <Ramona.Bolboaca@xxxxxxxxxx>
> Subject: [PATCH v3 01/10] iio: adis: add '__adis_enable_irq()' implementation
> 
> Add '__adis_enable_irq()' implementation which is the unlocked
> version of 'adis_enable_irq()'.
> 
> Signed-off-by: Ramona Bolboaca <ramona.bolboaca@xxxxxxxxxx>
> ---
> changes in v3:
>  - new patch
>  drivers/iio/imu/adis.c       | 26 +++++++++-----------------
>  include/linux/iio/imu/adis.h | 12 +++++++++++-
>  2 files changed, 20 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index f7fcfd04f659..cfcb4abeb5db 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -270,23 +270,19 @@ EXPORT_SYMBOL_NS(adis_debugfs_reg_access,
> IIO_ADISLIB);
>  #endif
> 
>  /**
> - * adis_enable_irq() - Enable or disable data ready IRQ
> + * __adis_enable_irq() - Enable or disable data ready IRQ (unlocked)
>   * @adis: The adis device
>   * @enable: Whether to enable the IRQ
>   *
>   * Returns 0 on success, negative error code otherwise
>   */
> -int adis_enable_irq(struct adis *adis, bool enable)
> +int __adis_enable_irq(struct adis *adis, bool enable)
>  {
> -	int ret = 0;
> +	int ret;

This change was not really needed as long as we 'return ret'
In the ' unmasked_drdy' case. Anyways, not a big deal for me...

- Nuno Sá