Re: [PATCH 1/8] spi: dt-bindings: Introduce spi-cs-setup-ns property
From: Mark Brown
Date: Fri Nov 18 2022 - 10:30:52 EST
On Fri, Nov 18, 2022 at 03:14:58PM +0100, Michael Walle wrote:
> From: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
> > + spi-cs-setup-ns:
> > + description:
> > + Delay in nanosecods to be introduced by the controller after CS is
> > + asserted.
> Does this need a type as the spi-cs-setup-ns is apparently just 16bit? At
> least the driver uses it that way.
> But IMHO this should just be a normal uint32 value to be consistent with
> all the other properties. Also the max value with 16bit will be 'just'
> 65us.
Making it 32 bit does seem safer. I've applied the series
already, mainly for the reintroduction of spi_set_cs_timing()
since there was another driver that needed it, but we can still
fix things up until the merge window.
Attachment:
signature.asc
Description: PGP signature