Aw: Re: [PATCH v5 07/11] arm64: dts: mt7986: add usb related device nodes

[Frank Wunderlich]

Hi

> Gesendet: Freitag, 18. November 2022 um 07:43 Uhr
> Von: "Chunfeng Yun (云春峰)" <Chunfeng.Yun@xxxxxxxxxxxx>
> On Thu, 2022-11-17 at 17:27 +0100, Frank Wunderlich wrote:
> > From: Sam Shih <sam.shih@xxxxxxxxxxxx>
> > 
> > This patch adds USB support for MT7986.
> > 
> > Signed-off-by: Sam Shih <sam.shih@xxxxxxxxxxxx>
> > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> > ---
> > changes compared to sams original version:
> > - reorder xhci-clocks based on yaml binding
> > 
> > v5:
> >  - update ranges/reg of usb-phy
> >  - not added RB from AngeloGioacchino for v4 because of these changes

> > diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> > b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> > index 006878e3f2b2..2b5d7ea31b4d 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> > +++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> > @@ -23,6 +23,24 @@ memory@40000000 {
> >  		device_type = "memory";
> >  		reg = <0 0x40000000 0 0x40000000>;
> >  	};
> > +
> > +	reg_3p3v: regulator-3p3v {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "fixed-3.3V";
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		regulator-boot-on;
> > +		regulator-always-on;
> > +	};
> > +
> > +	reg_5v: regulator-5v {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "fixed-5V";
> > +		regulator-min-microvolt = <5000000>;
> > +		regulator-max-microvolt = <5000000>;
> > +		regulator-boot-on;
> > +		regulator-always-on;
> > +	};
> >  };
> Usually if we use a gpio to control a switch to turn on/off power, we
> model it as a fixed regulator, but here no gpio provided in reg_3p3v
> and reg_5v, if no gpio used, no need these two fixed regulators too.

i can drop 5v regulator, but 3v3 is used by emmc, so i would move that to the mmc-patch

> >  
> >  &crypto {
> > @@ -140,6 +158,12 @@ &spi1 {
> >  	status = "okay";
> >  };
> >  
> > +&ssusb {
> > +	vusb33-supply = <&reg_3p3v>;
> > +	vbus-supply = <&reg_5v>;
> These two supply can be removed if no swith to control them, they are
> optional.

ok, i drop the references.

anything else ok?

prepared patch here (now yet squashed):
https://github.com/frank-w/BPI-R2-4.14/commits/6.1-r3dts

regards Frank