Re: [PATCH v5 6/6] zsmalloc: Implement writeback mechanism for zsmalloc

From: Nhat Pham
Date: Fri Nov 18 2022 - 17:08:21 EST


Thanks a lot for the suggestions so far and for the review, Minchan!
Quick question about your last comment:

>> +#ifdef CONFIG_ZPOOL
>
> Let's remove the ifdef machinery here.
>
>> + /* Free all deferred handles from zs_free */
>> + free_handles(pool, zspage);
>> +#endif

free_handles() here is for the deferred handle freeing, which is also
under CONFIG_ZPOOL now, so I don't think we should remove the #ifdef
CONFIG_ZPOOL here, no? Let me know if I'm misunderstanding your
suggestion, or if you have any further comments regarding this patch.