Re: [PATCH] KVM: VMX: Access @flags as a 32-bit value in __vmx_vcpu_run()

From: Jim Mattson
Date: Fri Nov 18 2022 - 22:17:32 EST


On Fri, Nov 18, 2022 at 5:33 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> Access @flags using 32-bit operands when saving and testing @flags for
> VMX_RUN_VMRESUME, as using 8-bit operands is unnecessarily fragile due
> to relying on VMX_RUN_VMRESUME being in bits 0-7. The behavior of
> treating @flags a single byte is a holdover from when the param was
> "bool launched", i.e. is not deliberate.
>
> Cc: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx>