Re: [PATCH 454/606] mfd: rohm-bd718x7: Convert to i2c's .probe_new()

[Matti Vaittinen]

On 11/19/22 00:43, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Acked-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>

> ---
>   drivers/mfd/rohm-bd718x7.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/rohm-bd718x7.c b/drivers/mfd/rohm-bd718x7.c
> index bfd81f78beae..3c766cb15a24 100644
> --- a/drivers/mfd/rohm-bd718x7.c
> +++ b/drivers/mfd/rohm-bd718x7.c
> @@ -127,8 +127,7 @@ static int bd718xx_init_press_duration(struct regmap *regmap,
>   	return 0;
>   }
>   
> -static int bd718xx_i2c_probe(struct i2c_client *i2c,
> -			    const struct i2c_device_id *id)
> +static int bd718xx_i2c_probe(struct i2c_client *i2c)
>   {
>   	struct regmap *regmap;
>   	struct regmap_irq_chip_data *irq_data;
> @@ -215,7 +214,7 @@ static struct i2c_driver bd718xx_i2c_driver = {
>   		.name = "rohm-bd718x7",
>   		.of_match_table = bd718xx_of_match,
>   	},
> -	.probe = bd718xx_i2c_probe,
> +	.probe_new = bd718xx_i2c_probe,
>   };
>   
>   static int __init bd718xx_i2c_init(void)

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~