Re: [PATCH 033/606] drm/bridge: tc358768: Convert to i2c's .probe_new()

From: Laurent Pinchart
Date: Sat Nov 19 2022 - 12:34:19 EST


On Fri, Nov 18, 2022 at 11:36:07PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

> ---
> drivers/gpu/drm/bridge/tc358768.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
> index 4c4b77ce8aba..839b8832b9b5 100644
> --- a/drivers/gpu/drm/bridge/tc358768.c
> +++ b/drivers/gpu/drm/bridge/tc358768.c
> @@ -1018,8 +1018,7 @@ static int tc358768_get_regulators(struct tc358768_priv *priv)
> return ret;
> }
>
> -static int tc358768_i2c_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int tc358768_i2c_probe(struct i2c_client *client)
> {
> struct tc358768_priv *priv;
> struct device *dev = &client->dev;
> @@ -1085,7 +1084,7 @@ static struct i2c_driver tc358768_driver = {
> .of_match_table = tc358768_of_ids,
> },
> .id_table = tc358768_i2c_ids,
> - .probe = tc358768_i2c_probe,
> + .probe_new = tc358768_i2c_probe,
> .remove = tc358768_i2c_remove,
> };
> module_i2c_driver(tc358768_driver);
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart