Re: [PATCH 352/606] media: i2c/mt9t001: Convert to i2c's .probe_new()

From: Laurent Pinchart
Date: Sat Nov 19 2022 - 12:45:04 EST


On Fri, Nov 18, 2022 at 11:41:26PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
> drivers/media/i2c/mt9t001.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/mt9t001.c b/drivers/media/i2c/mt9t001.c
> index d5abe4a7ef07..c635ed11388a 100644
> --- a/drivers/media/i2c/mt9t001.c
> +++ b/drivers/media/i2c/mt9t001.c
> @@ -856,8 +856,7 @@ static const struct v4l2_subdev_internal_ops mt9t001_subdev_internal_ops = {
> .close = mt9t001_close,
> };
>
> -static int mt9t001_probe(struct i2c_client *client,
> - const struct i2c_device_id *did)
> +static int mt9t001_probe(struct i2c_client *client)
> {
> struct mt9t001_platform_data *pdata = client->dev.platform_data;
> struct mt9t001 *mt9t001;
> @@ -981,7 +980,7 @@ static struct i2c_driver mt9t001_driver = {
> .driver = {
> .name = "mt9t001",
> },
> - .probe = mt9t001_probe,
> + .probe_new = mt9t001_probe,
> .remove = mt9t001_remove,
> .id_table = mt9t001_id,
> };
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart