[PATCH net-next] devlink: remove redundant health state set to error
From: Moshe Shemesh
Date: Sun Nov 20 2022 - 03:40:02 EST
Reporter health_state is set twice to error in devlink_health_report().
Remove second time as it is redundant.
Signed-off-by: Moshe Shemesh <moshe@xxxxxxxxxx>
Reviewed-by: Eran Ben Elisha <eranbe@xxxxxxxxxx>
---
net/core/devlink.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index d93bc95cd7cb..cea154ddce7a 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -7846,8 +7846,6 @@ int devlink_health_report(struct devlink_health_reporter *reporter,
return -ECANCELED;
}
- reporter->health_state = DEVLINK_HEALTH_REPORTER_STATE_ERROR;
-
if (reporter->auto_dump) {
mutex_lock(&reporter->dump_lock);
/* store current dump of current error, for later analysis */
--
2.26.3