Re: [PATCH v2 2/2] dt-bindings: iio: adc: ad7923: adjust documentation
From: Rob Herring
Date: Sun Nov 20 2022 - 10:34:25 EST
On Sun, Nov 20, 2022 at 01:45:43PM +0100, Edmund Berenson wrote:
> - Add the ad7927 compatibility string, with fallback compatibility
> to ad7928.
> - ad7923 and ad7924 are treated the same in the driver, show
> the relationship in the documentation.
>
> Suggested-by: Lukasz Zemla <Lukasz.Zemla@xxxxxxxxxxxx>
> Signed-off-by: Edmund Berenson <edmund.berenson@xxxxxxxxx>
> ---
> .../bindings/iio/adc/adi,ad7923.yaml | 21 +++++++++++--------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> index 07f9d1c09c7d..165c4b6863e0 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> @@ -11,7 +11,7 @@ maintainers:
>
> description: |
> Analog Devices AD7904, AD7914, AD7923, AD7924 4 Channel ADCs, and AD7908,
> - AD7918, AD7928 8 Channels ADCs.
> + AD7918, AD7927, AD7928 8 Channels ADCs.
>
> Specifications about the part can be found at:
> https://www.analog.com/media/en/technical-documentation/data-sheets/AD7923.pdf
> @@ -20,14 +20,17 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - adi,ad7904
> - - adi,ad7914
> - - adi,ad7923
> - - adi,ad7924
> - - adi,ad7908
> - - adi,ad7918
> - - adi,ad7928
> + oneOf:
> + - const: adi,ad7904
> + - const: adi,ad7914
> + - items:
> + - const: adi,ad7923
> + - const: adi,ad7924
> + - const: adi,ad7908
> + - const: adi,ad7918
All the single entry 'const' cases can remain an 'enum'.
> + - items:
> + - const: adi,ad7927
> + - const: adi,ad7928
>
> reg:
> maxItems: 1
> --
> 2.37.4
>
>