Re: [PATCH] dt-bindings: pinctrl: qcom,sdm845-pinctrl: add GPIO hogs
From: Rob Herring
Date: Sun Nov 20 2022 - 11:41:47 EST
On Fri, Nov 18, 2022 at 05:21:01PM +0100, Krzysztof Kozlowski wrote:
> Allow GPIO hogs in pin controller node. qcom/sdm845-cheza.dtsi already
> uses it.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> .../bindings/pinctrl/qcom,sdm845-pinctrl.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
> index c9627777ceb3..57bac7f7a4fc 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
> @@ -48,6 +48,11 @@ patternProperties:
> $ref: "#/$defs/qcom-sdm845-tlmm-state"
> additionalProperties: false
>
> + "-hog(-[0-9]+)?$":
> + $ref: /schemas/gpio/gpio-hog.yaml
You can drop this and just do:
required:
- gpio-hog
As that's what selects the hog schema. Kind of an odd pattern I guess.
We could make gpio.yaml define hog nodes instead I suppose.
> + type: object
> + unevaluatedProperties: false
> +