Re: [PATCH v4 2/4] accel: add dedicated minor for accelerator devices

[Jeffrey Hugo]

On 11/19/2022 1:44 PM, Oded Gabbay wrote:
> diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_accel.c
> index fac6ad6ac28e..703d40c4ff45 100644
> --- a/drivers/accel/drm_accel.c
> +++ b/drivers/accel/drm_accel.c
> @@ -8,14 +8,25 @@
>
>   #include <linux/debugfs.h>
>   #include <linux/device.h>
> +#include <linux/xarray.h>

Including xarray, but using idr
This should be linux/idr.h

This seems so minor, I don't think I advise spinning a v5 for it.  If a 
v5 is warranted elsewhere, obviously fix this.  If not, hopefully this 
can be fixed up by whoever applies it, or someone submits a follow up patch.

Hopefully this is the only nit.  I would like to see this merged.

-Jeff