Re: [RFC PATCH] afs: Stop implementing ->writepage()

From: Christoph Hellwig
Date: Mon Nov 21 2022 - 03:33:17 EST


On Mon, Nov 21, 2022 at 08:28:57AM +0000, David Howells wrote:
> > That would be much preferred over the for_write_begin hack, given that
> > write_begin really isn't a well defined method but a hacky hook for
> > legacy write implementations.
>
> So I don't need to worry about the control group stuff? I'll still need some
> way to flush a conflicting write whatever mechanism is being used to write to
> the page cache.

cgroup is used for throttling writeback. If you need to flush conflicting
writes I can't see how interacting with the cgroups benefits anyone.

An as far as I can tell afs doesn't support cgroup writeback to start
with.