Re: [PATCH v5 09/14] serial: liteuart: fix rx loop variable types

[Jiri Slaby]

On 21. 11. 22, 9:37, Jiri Slaby wrote:
> On 18. 11. 22, 15:55, Gabriel Somlo wrote:
> > Update variable types to match the signature of uart_insert_char()
> > which consumes them.
> >
> > Signed-off-by: Gabriel Somlo <gsomlo@xxxxxxxxx>
> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/tty/serial/liteuart.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/tty/serial/liteuart.c 
> > b/drivers/tty/serial/liteuart.c
> > index 81aa7c1da73c..42ac9aee050a 100644
> > --- a/drivers/tty/serial/liteuart.c
> > +++ b/drivers/tty/serial/liteuart.c
> > @@ -73,8 +73,7 @@ static void liteuart_timer(struct timer_list *t)
> >       struct liteuart_port *uart = from_timer(uart, t, timer);
> >       struct uart_port *port = &uart->port;
> >       unsigned char __iomem *membase = port->membase;
> > -    int ch;
> > -    unsigned long status;
> > +    unsigned int status, ch;
>
> These should be u8 after all, right?

And can you change membase to u8 * too 8-)?

--
js
suse labs