Re: [PATCH 578/606] usb: typec: hd3ss3220: Convert to i2c's .probe_new()

From: Heikki Krogerus
Date: Mon Nov 21 2022 - 04:06:15 EST


On Fri, Nov 18, 2022 at 11:45:12PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
> drivers/usb/typec/hd3ss3220.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
> index 2a58185fb14c..f128664cb130 100644
> --- a/drivers/usb/typec/hd3ss3220.c
> +++ b/drivers/usb/typec/hd3ss3220.c
> @@ -148,8 +148,7 @@ static const struct regmap_config config = {
> .max_register = 0x0A,
> };
>
> -static int hd3ss3220_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int hd3ss3220_probe(struct i2c_client *client)
> {
> struct typec_capability typec_cap = { };
> struct hd3ss3220 *hd3ss3220;
> @@ -264,7 +263,7 @@ static struct i2c_driver hd3ss3220_driver = {
> .name = "hd3ss3220",
> .of_match_table = of_match_ptr(dev_ids),
> },
> - .probe = hd3ss3220_probe,
> + .probe_new = hd3ss3220_probe,
> .remove = hd3ss3220_remove,
> };
>

thanks,

--
heikki