Re: [PATCH 581/606] usb: typec: tcpm/tcpci_maxim: Convert to i2c's .probe_new()

[Heikki Krogerus]

On Fri, Nov 18, 2022 at 11:45:15PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>  drivers/usb/typec/tcpm/tcpci_maxim.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
> index 03f89e6f1a78..83e140ffcc3e 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
> @@ -438,7 +438,7 @@ static int tcpci_init(struct tcpci *tcpci, struct tcpci_data *data)
>  	return -1;
>  }
>  
> -static int max_tcpci_probe(struct i2c_client *client, const struct i2c_device_id *i2c_id)
> +static int max_tcpci_probe(struct i2c_client *client)
>  {
>  	int ret;
>  	struct max_tcpci_chip *chip;
> @@ -519,7 +519,7 @@ static struct i2c_driver max_tcpci_i2c_driver = {
>  		.name = "maxtcpc",
>  		.of_match_table = of_match_ptr(max_tcpci_of_match),
>  	},
> -	.probe = max_tcpci_probe,
> +	.probe_new = max_tcpci_probe,
>  	.remove = max_tcpci_remove,
>  	.id_table = max_tcpci_id,
>  };

thanks,

-- 
heikki