Re: [PATCH v1 0/8] Redesign the pmc core driver

[Hans de Goede]

Hi,

On 11/14/22 19:32, Gayatri Kammela wrote:
> This patch series focuses on redesigning the PMC core driver for
> maintainability and readability. Moving PCH specific structures and
> functions to separate c files, simplifies core.c file and makes it
> easier to add new platforms in future. The series includes two
> preparatory patches that lays the ground work for the redesign. The
> patch series also adds legacy support for Meteor Lake.
> 
> This redesign adds following c files to support different PCHs. There
> are no functional changes involved for the already supported platforms.
> 
> spt.c: Sunrise Point PCH supports: Sky Lake, Sky Lake L, Kaby Lake,
> Kaby Lake L
> cnp.c: Cannon Lake Point PCH supports: Cannon Lake L, Comet Lake,
> Comet Lake L
> icl.c: Ice Lake PCH supports: Ice Lake L, Ice Lake NNPI, Jasper Lake
> tgl.c: Tiger Lake PCH supports: Tiger Lake, Tiger Lake L, Alder Lake L,
> Alder Lake N, Rocket Lake, Raptor Lake P, Elkhart Lake
> adl.c: Alder Lake PCH supports: Alder Lake, Raptor Lake, Raptor Lake S
> mtl.c: Meteor Lake PCH supports: Meteor Lake
> 
> Patch 1: platform/x86: intel/pmc: Replace all the reg_map with init
> functions
> Patch 2: platform/x86: intel/pmc: Move variable declarations and
> definitions to header and core.c
> Patch 3: platform/x86: intel/pmc: Relocate Sunrise Point PCH support
> Patch 4: platform/x86: intel/pmc: Relocate Cannon Lake Point PCH
> support
> Patch 5: platform/x86: intel/pmc: Relocate Ice Lake PCH support
> Patch 6: platform/x86: intel/pmc: Relocate Tiger Lake PCH support
> Patch 7: platform/x86: intel/pmc: Relocate Alder Lake PCH support
> Patch 8: platform/x86: intel/pmc: Add Meteor Lake support to pmc core
> driver

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans






> Gayatri Kammela (4):
>   platform/x86: intel/pmc: Replace all the reg_map with init functions
>   platform/x86: intel/pmc: Relocate Tiger Lake PCH support
>   platform/x86: intel/pmc: Relocate Alder Lake PCH support
>   platform/x86: intel/pmc/core: Add Meteor Lake support to pmc core
>     driver
> 
> Rajvi Jingar (1):
>   platform/x86: intel/pmc: Relocate Sunrise Point PCH support
> 
> Xi Pardee (3):
>   platform/x86: intel/pmc: Move variable declarations and definitions to
>     header and core.c
>   platform/x86: intel/pmc: Relocate Cannon Lake Point PCH support
>   platform/x86: intel/pmc: Relocate Ice Lake PCH support
> 
>  drivers/platform/x86/intel/pmc/Makefile |   3 +-
>  drivers/platform/x86/intel/pmc/adl.c    | 325 ++++++++
>  drivers/platform/x86/intel/pmc/cnp.c    | 210 +++++
>  drivers/platform/x86/intel/pmc/core.c   | 994 ++----------------------
>  drivers/platform/x86/intel/pmc/core.h   |  89 ++-
>  drivers/platform/x86/intel/pmc/icl.c    |  56 ++
>  drivers/platform/x86/intel/pmc/mtl.c    |  52 ++
>  drivers/platform/x86/intel/pmc/spt.c    | 140 ++++
>  drivers/platform/x86/intel/pmc/tgl.c    | 269 +++++++
>  9 files changed, 1183 insertions(+), 955 deletions(-)
>  create mode 100644 drivers/platform/x86/intel/pmc/adl.c
>  create mode 100644 drivers/platform/x86/intel/pmc/cnp.c
>  create mode 100644 drivers/platform/x86/intel/pmc/icl.c
>  create mode 100644 drivers/platform/x86/intel/pmc/mtl.c
>  create mode 100644 drivers/platform/x86/intel/pmc/spt.c
>  create mode 100644 drivers/platform/x86/intel/pmc/tgl.c
> 
> 
> base-commit: 309e0a6ed6e3fdb4febacc3e91aeb268500b90c6
> 
> Cc: Xi Pardee <xi.pardee@xxxxxxxxx>
> Cc: Rajvi Jingar <rajvi.jingar@xxxxxxxxxxxxxxx>
> Cc: David E Box <david.e.box@xxxxxxxxxxxxxxx>