RE: [PATCH 585/606] backlight: adp8860: Convert to i2c's .probe_new()

[Hennerich, Michael]

> -----Original Message-----
> From: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>
> Sent: Freitag, 18. November 2022 23:45
> To: Angel Iglesias <ang.iglesiasg@xxxxxxxxx>; Lee Jones
> <lee.jones@xxxxxxxxxx>; Grant Likely <grant.likely@xxxxxxxxxx>; Wolfram
> Sang <wsa@xxxxxxxxxx>; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>; Lee Jones <lee@xxxxxxxxxx>; Daniel
> Thompson <daniel.thompson@xxxxxxxxxx>; Jingoo Han
> <jingoohan1@xxxxxxxxx>; Helge Deller <deller@xxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-
> fbdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH 585/606] backlight: adp8860: Convert to i2c's .probe_new()
> 
> 
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> .probe_new() doesn't get the i2c_device_id * parameter, so determine that
> explicitly in the probe function.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

> ---
>  drivers/video/backlight/adp8860_bl.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/video/backlight/adp8860_bl.c
> b/drivers/video/backlight/adp8860_bl.c
> index b0fe02273e87..a479aab90f78 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -648,9 +648,9 @@ static const struct attribute_group
> adp8860_bl_attr_group = {
>  	.attrs = adp8860_bl_attributes,
>  };
> 
> -static int adp8860_probe(struct i2c_client *client,
> -					const struct i2c_device_id *id)
> +static int adp8860_probe(struct i2c_client *client)
>  {
> +	const struct i2c_device_id *id = i2c_client_get_device_id(client);
>  	struct backlight_device *bl;
>  	struct adp8860_bl *data;
>  	struct adp8860_backlight_platform_data *pdata = @@ -803,7 +803,7
> @@ static struct i2c_driver adp8860_driver = {
>  		.name	= KBUILD_MODNAME,
>  		.pm	= &adp8860_i2c_pm_ops,
>  	},
> -	.probe    = adp8860_probe,
> +	.probe_new = adp8860_probe,
>  	.remove   = adp8860_remove,
>  	.id_table = adp8860_id,
>  };
> --
> 2.38.1