RE: [PATCH 513/606] power: supply: adp5061: Convert to i2c's .probe_new()
From: Hennerich, Michael
Date: Mon Nov 21 2022 - 04:47:05 EST
> -----Original Message-----
> From: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>
> Sent: Freitag, 18. November 2022 23:44
> To: Angel Iglesias <ang.iglesiasg@xxxxxxxxx>; Lee Jones
> <lee.jones@xxxxxxxxxx>; Grant Likely <grant.likely@xxxxxxxxxx>; Wolfram
> Sang <wsa@xxxxxxxxxx>; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>; Sebastian Reichel <sre@xxxxxxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx>; linux-pm@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH 513/606] power: supply: adp5061: Convert to i2c's
> .probe_new()
>
>
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> ---
> drivers/power/supply/adp5061.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/supply/adp5061.c
> b/drivers/power/supply/adp5061.c index fcf8ff0bc974..840db629a46c
> 100644
> --- a/drivers/power/supply/adp5061.c
> +++ b/drivers/power/supply/adp5061.c
> @@ -694,8 +694,7 @@ static const struct power_supply_desc adp5061_desc
> = {
> .num_properties = ARRAY_SIZE(adp5061_props),
> };
>
> -static int adp5061_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int adp5061_probe(struct i2c_client *client)
> {
> struct power_supply_config psy_cfg = {};
> struct adp5061_state *st;
> @@ -737,7 +736,7 @@ static struct i2c_driver adp5061_driver = {
> .driver = {
> .name = KBUILD_MODNAME,
> },
> - .probe = adp5061_probe,
> + .probe_new = adp5061_probe,
> .id_table = adp5061_id,
> };
> module_i2c_driver(adp5061_driver);
> --
> 2.38.1