RE: [PATCH 192/606] Input: adp5588-keys - Convert to i2c's .probe_new()

[Hennerich, Michael]

> -----Original Message-----
> From: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>
> Sent: Freitag, 18. November 2022 23:39
> To: Angel Iglesias <ang.iglesiasg@xxxxxxxxx>; Lee Jones
> <lee.jones@xxxxxxxxxx>; Grant Likely <grant.likely@xxxxxxxxxx>; Wolfram
> Sang <wsa@xxxxxxxxxx>; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>; Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx>; linux-input@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH 192/606] Input: adp5588-keys - Convert to i2c's
> .probe_new()
> 
> 
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

> ---
>  drivers/input/keyboard/adp5588-keys.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/keyboard/adp5588-keys.c
> b/drivers/input/keyboard/adp5588-keys.c
> index 7cd83c8e7110..72ae5ce72956 100644
> --- a/drivers/input/keyboard/adp5588-keys.c
> +++ b/drivers/input/keyboard/adp5588-keys.c
> @@ -718,8 +718,7 @@ static void adp5588_disable_regulator(void *reg)
>  	regulator_disable(reg);
>  }
> 
> -static int adp5588_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int adp5588_probe(struct i2c_client *client)
>  {
>  	struct adp5588_kpad *kpad;
>  	struct input_dev *input;
> @@ -867,7 +866,7 @@ static struct i2c_driver adp5588_driver = {
>  		.of_match_table = adp5588_of_match,
>  		.pm   = pm_sleep_ptr(&adp5588_dev_pm_ops),
>  	},
> -	.probe    = adp5588_probe,
> +	.probe_new = adp5588_probe,
>  	.remove   = adp5588_remove,
>  	.id_table = adp5588_id,
>  };
> --
> 2.38.1