Re: [PATCH 166/606] iio: pressure: bmp280-i2c: Convert to i2c's .probe_new()

[Uwe Kleine-König]

Hello,

On Fri, Nov 18, 2022 at 11:38:20PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
>  drivers/iio/pressure/bmp280-i2c.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/pressure/bmp280-i2c.c b/drivers/iio/pressure/bmp280-i2c.c
> index 14eab086d24a..4da014b158c8 100644
> --- a/drivers/iio/pressure/bmp280-i2c.c
> +++ b/drivers/iio/pressure/bmp280-i2c.c
> @@ -7,6 +7,7 @@
>  
>  static int bmp280_i2c_probe(struct i2c_client *client)
>  {
> +	const struct i2c_device_id *id = i2c_client_get_device_id(client);
>  	struct regmap *regmap;
>  	const struct regmap_config *regmap_config;
>  	const struct i2c_device_id *id = i2c_client_get_device_id(client);

This patch is bogus, it degraded by rebasing on top of Angel Iglesias's
conversion (021882de1a48cffaa405aa8014bd1d48ca6d5c19 in today's next).

I dropped it from my queue, please don't apply.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature