Re: [PATCH v2 3/3] arm64: dts: qcom: sc8280xp: Add soundcard support

[Srinivas Kandagatla]

Thanks Krzysztof,

On 21/11/2022 08:34, Krzysztof Kozlowski wrote:
> On 19/11/2022 17:44, Srinivas Kandagatla wrote:
> > Add support for SoundCard on X13s. This patch adds support for Headset
> > Playback, record and 2 DMICs on the Panel along with the regulators
> > required for powering up the LPASS codecs.
> >
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > ---
>
> Thank you for your patch. There is something to discuss/improve.
>
> > +	right_spkr: wsa8830-right@0,2{
> > +		compatible = "sdw10217020200";
> > +		reg = <0 2>;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&spkr_2_sd_n_default>;
> > +		powerdown-gpios = <&tlmm 179 GPIO_ACTIVE_LOW>;
> > +		#thermal-sensor-cells = <0>;
> > +		sound-name-prefix = "SpkrRight";
> > +		#sound-dai-cells = <0>;
> > +		vdd-supply = <&vreg_s10b>;
> > +	};
> > +};
> > +
> > +
>
> Only one blank line.
>
> > +&swr1 {
> > +	status = "okay";
> > +
> > +	wcd_rx: wcd9380-rx@0,4 {
> > +		compatible = "sdw20217010d00";
> > +		reg = <0 4>;
> > +		qcom,rx-port-mapping = <1 2 3 4 5 6>;
>
> No improvements: Still looks too long.
Yep we only have 5 out ports.

> > +
>
> Drop empty line.

Looks like I had to many stray lines :-)

will fix this in next spin.

> > +	};
> > +};
> > +
> > +&swr2 {
> > +	status = "okay";
> > +
> > +	wcd_tx: wcd9380-tx@0,3 {
> > +		compatible = "sdw20217010d00";
> > +		reg = <0 3>;
> > +		qcom,tx-port-mapping = <1 1 2 3>;
> > +	};
> > +};
> > +
> > +&vamacro {
> > +	pinctrl-0 = <&dmic01_default>, <&dmic02_default>;
> > +	pinctrl-names = "default";
> > +	vdd-micb-supply = <&vreg_s10b>;
> > +	qcom,dmic-sample-rate = <600000>;
> > +};
> > +
> >   &tlmm {
> >   	gpio-reserved-ranges = <70 2>, <74 6>, <83 4>, <125 2>, <128 2>, <154 7>;
> >   
> > @@ -369,6 +558,14 @@ reset {
> >   		};
> >   	};
> >   
> > +	wcd_default: wcd-default-state {
> > +		reset-pins {
> > +			pins = "gpio106";
> > +			function = "gpio";
> > +			bias-disable;
> > +		};
> > +	};
> > +
> >   	qup0_i2c4_default: qup0-i2c4-default-state {
> >   		pins = "gpio171", "gpio172";
> >   		function = "qup4";
> > @@ -383,6 +580,26 @@ qup2_i2c5_default: qup2-i2c5-default-state {
> >   		drive-strength = <16>;
> >   	};
> >   
> > +	spkr_1_sd_n_default: spkr-1-sd-n-default-state {
> > +		perst-n-pins {
> > +			pins = "gpio178";
> > +			function = "gpio";
> > +			drive-strength = <16>;
> > +			bias-disable;
> > +			output-high;
> > +		};
> > +	};
> > +
> > +	spkr_2_sd_n_default: spkr-2-sd-n-default-state {
> > +		perst-n-pins {
> > +			pins = "gpio179";
> > +			function = "gpio";
> > +			drive-strength = <16>;
> > +			bias-disable;
> > +			output-high;
> > +		};
> > +	};
> > +
> >   	tpad_default: tpad-default-state {
> >   		int-n {
>
> This won't apply cleanly. You need to base your patches on recent trees.

Yes, I will rebase this on top of 
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/log/?h=arm64-for-6.2

--srini
> Best regards,
> Krzysztof