On Sat, Nov 19, 2022 at 07:25:16PM +0100, Naresh Solanki wrote:Sure
From: Patrick Rudolph <patrick.rudolph@xxxxxxxxxxxxx>Change log should be after '---'
Add get_status for pmbus_regulator_ops.
Changes:
- use lock throughout the function
- Avoid line continuation upto 100 column
- Optimize use of & and | operator
- Check for VOUT, IOUT, TEMPERATURE bit in status word before checking
respective status register for fault.
- Report regulator current status.
Sure. But looking at get_status scope, I feel that we are already checking the following:
Also, when looking into this, I realized that we already have
pmbus_regulator_get_error_flags() which has somewhat overlapping
functionality. Would it be possible to utilize that function to get
the error status instead of more or less hand-coding it ?
Thanks,
Guenter