Re: [PATCH v2 1/2] leds: trigger: pattern: minor code style changes

From: Andy Shevchenko
Date: Mon Nov 21 2022 - 08:29:08 EST


On Mon, Nov 21, 2022 at 2:39 PM Martin Kurbanov
<mmkurbanov@xxxxxxxxxxxxxx> wrote:
>
> This patch adds some minor code style changes:
> - remove a blank line before DEVICE_ATTR_RW declarations
> - convert sysfs scnprintf() to sysfs_emit()/sysfs_emit_at()
> - use module_led_trigger instead of pattern_trig_init/exit
>
> Signed-off-by: Martin Kurbanov <mmkurbanov@xxxxxxxxxxxxxx>

...

> + count += sysfs_emit_at(buf, count,
> + "%d %u ",

With this getting shorter you may put these to one line.

> + data->patterns[i].brightness,
> + data->patterns[i].delta_t);

...

> -static int __init pattern_trig_init(void)
> -{
> - return led_trigger_register(&pattern_led_trigger);
> -}
> -
> -static void __exit pattern_trig_exit(void)
> -{
> - led_trigger_unregister(&pattern_led_trigger);
> -}
> -
> -module_init(pattern_trig_init);
> -module_exit(pattern_trig_exit);
> +module_led_trigger(pattern_led_trigger);

This should be a separate patch.

...

Otherwise this looks good to me.

--
With Best Regards,
Andy Shevchenko