Re: [PATCH -next] pinctrl: pinctrl-loongson2: fix Kconfig dependency

[Ren Zhijie]

Hi all,

    I misspell the email address of linus, please ignore this email. 
Thanks.

Ren

在 2022/11/21 21:14, Ren Zhijie 写道:
> If CONFIG_PINCTRL_LOONGSON2=y and CONFIG_OF is not set,
> gcc complained about undefined reference:
>
> drivers/pinctrl/pinctrl-loongson2.o: In function `pinconf_generic_dt_node_to_map_all':
> pinctrl-loongson2.c:(.text+0x1c4): undefined reference to
> `pinconf_generic_dt_node_to_map'
>
> To fix this error, add depends on OF to
> config PINCTRL_LOONGSON2.
>
> Fixes: f73f88acbc18 ("pinctrl: pinctrl-loongson2: add pinctrl driver support")
> Signed-off-by: Ren Zhijie <renzhijie2@xxxxxxxxxx>
> ---
>   drivers/pinctrl/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 35f167f70829..7d5f5458c72e 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -260,7 +260,7 @@ config PINCTRL_FALCON
>   
>   config PINCTRL_LOONGSON2
>   	tristate "Pinctrl driver for the Loongson-2 SoC"
> -	depends on LOONGARCH || COMPILE_TEST
> +	depends on OF && (LOONGARCH || COMPILE_TEST)
>   	select PINMUX
>   	select GENERIC_PINCONF
>   	help