Re: [PATCH for-6.2/hid-bpf] HID: force HID depending on INPUT

From: Jiri Kosina
Date: Mon Nov 21 2022 - 12:37:51 EST


On Fri, 18 Nov 2022, Benjamin Tissoires wrote:

> In most configurations, INPUT is actually a boolean: either y or disabled,
> but when it's disabled, you can't do much on your average laptop.
>
> But it turns out that there is a possibility to have INPUT as a module:
> you have to disable VT and TTY (of course), but also enable EXPERT.
> I'll leave how to disable VT and TTY as an exercise for the bravest.
>
> Anyway, if INPUT is m, we can still configure HID as y, which is not
> correct because hid-input.c depends on the input API, meaning that
> vmlinuz can not link.
>
> So: add depends on INPUT too at the HID level, to ensure that if INPUT=m,
> HID can only be m or disabled.
>
> Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Link: https://lore.kernel.org/r/202211181742.QYJY6Gug-lkp@xxxxxxxxx
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

Applied as well to for-6.2/hid-bpf. Thanks,

--
Jiri Kosina
SUSE Labs