Re: [PATCH] netfilter: nf_flow_table: add missing locking

From: Felix Fietkau
Date: Mon Nov 21 2022 - 15:08:27 EST


On 21.11.22 20:47, Eric Dumazet wrote:
On Mon, Nov 21, 2022 at 11:45 AM Felix Fietkau <nbd@xxxxxxxx> wrote:

On 21.11.22 19:26, Felix Fietkau wrote:
> nf_flow_table_block_setup and the driver TC_SETUP_FT call can modify the flow
> block cb list while they are being traversed elsewhere, causing a crash.
> Add a write lock around the calls to protect readers
>
> Signed-off-by: Felix Fietkau <nbd@xxxxxxxx>
Sorry, I forgot to add this:

Reported-by: Chad Monroe <chad.monroe@xxxxxxxxxxx>

- Felix

Hi Felix

Could you also add a Fixes: tag ?
I don't know which commit to use for that tag.

- Felix