Re: [PATCH v7 01/20] x86/tdx: Define TDX supported page sizes as macros

From: Dave Hansen
Date: Mon Nov 21 2022 - 18:48:54 EST


On 11/20/22 16:26, Kai Huang wrote:
> +/*
> + * TDX supported page sizes (4K/2M/1G).
> + *
> + * Those values are part of the TDX module ABI. Do not change them.
> + */
> +#define TDX_PS_4K 0
> +#define TDX_PS_2M 1
> +#define TDX_PS_1G 2

That comment can just be:

/* TDX supported page sizes from the TDX module ABI. */

I think folks understand that the kernel can't willy nilly change ABI
values.