Re: [PATCH v1 6/8] drm: rcar-du: Add r8a779g0 support

[Tomi Valkeinen]

On 22/11/2022 05:05, Laurent Pinchart wrote:
> On Thu, Nov 17, 2022 at 03:08:38PM +0000, Kieran Bingham wrote:
> > Quoting Tomi Valkeinen (2022-11-17 12:25:45)
> > > From: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
> > >
> > > Add support for DU on r8a779g0, which is identical to DU on r8a779a0.
> > >
> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
> > > ---
> > >   drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++++++++++++++++++++++
> > >   1 file changed, 22 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > > index d003e8d9e7a2..b1761d4ec4e5 100644
> > > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > > @@ -524,6 +524,27 @@ static const struct rcar_du_device_info rcar_du_r8a779a0_info = {
> > >          .dsi_clk_mask =  BIT(1) | BIT(0),
> > >   };
> > >   
> > > +static const struct rcar_du_device_info rcar_du_r8a779g0_info = {
> > > +       .gen = 3,
> >
> > Given that this is the V4H ... I wonder if this should be bumped
> > already. I guess that has knock on effects through the driver though...
>
> rcar_du_group_setup_didsr() would need to be fixed to test gen >= 3
> instead of gen == 3. That seems to be the only problematic location. It
> could thus fairly easily be done in v2, but we can also delay it.

Ok, I can fix that here.

 Tomi