Re: [PATCH 171/606] iio: pressure: icp10100: Convert to i2c's .probe_new()

From: Jean-Baptiste Maneyrol
Date: Tue Nov 22 2022 - 05:08:13 EST


Hello,

looks good, thanks for the patch.

Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx>

Best regards,
JB



From: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>
Sent: Friday, November 18, 2022 23:38
To: Angel Iglesias <ang.iglesiasg@xxxxxxxxx>; Lee Jones <lee.jones@xxxxxxxxxx>; Grant Likely <grant.likely@xxxxxxxxxx>; Wolfram Sang <wsa@xxxxxxxxxx>; Jonathan Cameron <jic23@xxxxxxxxxx>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@xxxxxxx>
Cc: linux-i2c@xxxxxxxxxxxxxxx <linux-i2c@xxxxxxxxxxxxxxx>; kernel@xxxxxxxxxxxxxx <kernel@xxxxxxxxxxxxxx>; Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx <linux-iio@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>
Subject: [PATCH 171/606] iio: pressure: icp10100: Convert to i2c's .probe_new()
 
[CAUTION] This is an EXTERNAL email. Do not click links or open attachments unless you recognize the sender and know the content is safe.

======================================================================
From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
---
 drivers/iio/pressure/icp10100.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/pressure/icp10100.c b/drivers/iio/pressure/icp10100.c
index b62f28585db5..407cf25ea0e3 100644
--- a/drivers/iio/pressure/icp10100.c
+++ b/drivers/iio/pressure/icp10100.c
@@ -530,8 +530,7 @@ static void icp10100_pm_disable(void *data)
         pm_runtime_disable(dev);
 }
 
-static int icp10100_probe(struct i2c_client *client,
-                         const struct i2c_device_id *id)
+static int icp10100_probe(struct i2c_client *client)
 {
         struct iio_dev *indio_dev;
         struct icp10100_state *st;
@@ -649,7 +648,7 @@ static struct i2c_driver icp10100_driver = {
                 .pm = pm_ptr(&icp10100_pm),
                 .of_match_table = icp10100_of_match,
         },
-       .probe = icp10100_probe,
+       .probe_new = icp10100_probe,
         .id_table = icp10100_id,
 };
 module_i2c_driver(icp10100_driver);
--
2.38.1