Re: [PATCH v3 1/4] x86/of: Convert Intel's APIC bindings to YAML schema
From: Rahul Tanwar
Date: Tue Nov 22 2022 - 05:44:58 EST
On 22/11/2022 6:09 pm, Andy Shevchenko wrote:
> This email was sent from outside of MaxLinear.
>
>
> On Tue, Nov 22, 2022 at 09:43:12AM +0000, Rahul Tanwar wrote:
>> On 22/11/2022 5:11 pm, Andy Shevchenko wrote:
>>> On Tue, Nov 22, 2022 at 03:39:07PM +0800, Rahul Tanwar wrote:
>
> ...
>
>>> > + first appeared in CE4100 SoC. See bindings/x86/ce4100.txt for more
>>>
>>> Shouldn't you change this?
>>
>> Do you mean change compatibility property prefix from
>> "intel,ce4100-ioapic" to "intel,ioapic"? If yes, then i totally agree
>> and i will change it (including new file names & all other references to
>> ce4100). If not, please clarify more..
>
> I specifically emphasized a single line (by putting blank lines around).
> For your convenience I removed the unneeded parts of the context, so you can
> see better what I meant.
>
Got it. I will remove the mention of "See bindings/x86/ce4100.txt" from
here.
> ...
>
>>> > + first appeared in CE4100 SoC. See bindings/x86/ce4100.txt for more
>
>
> Ditto.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
>